Implement HardDriveMediaDevicePath (along with MBR and GPT tests).
#497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
feature/hard-drive-media-device-path
branch
from
bb20062
to
5904c16
Compare
nicholasbishop
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
HardDriveMediaDevicePathspecialization ofDevicePathNode.I basically looked at the existing
FilePathMediaDevicePathand added the new structure with a similar API.This has been tested on the TianoCore UEFI of QEMU.
I've also added unit tests against the raw bytes of
HardDriveMediaDevicePathfor an MBR and a GPT partition.