Simplify serial usage in test-runner and check that tests completed #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
bishop-single-serial-device
branch
from
8614241 to
a869811
Compare
nicholasbishop
force-pushed
the
bishop-single-serial-device
branch
from
a869811 to
0752e84
Compare
Use `Box<dyn ...>` instead. No functional change, just reduces the need to add generic parameters outside of the `Io` implementation.
Use `assert!` rather than `assert_eq!` so that if the screenshot comparison fails, we don't dump all the raw pixel data to the console.
The screenshot test sends a command to the host via the serial device, then waits for a reply before continuing. We used a second serial device just for this request and reply so that we could open the protocol in exclusive mode without breaking logging for tests after that. It turns out there's a simpler way to do this: we can use the same serial device as the one used for logs, and after we're finished use `connect_controller` to restore the connection between the serial device and the console output.
At the end of the test-runner app, right before we exit boot services, send a TestsComplete message to the host. If the host doesn't receive this message, the tests will be marked as failed.
phip1611
force-pushed
the
bishop-single-serial-device
branch
from
0752e84 to
c05a9e0
Compare
phip1611
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a number of related improvements to the test runner. The main changes are:
connect_controller.TESTS_COMPLETEmessage that's sent the same way as theSCREENSHOTmessage. This is used to signal at the end of the tests that they completed successfully. If the host never receives that message, it exits with an error.Checklist