Skip to content

Implement the rest of the TPM v1 interface #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 9, 2023
Merged

Implement the rest of the TPM v1 interface #631

merged 6 commits into from
Jan 9, 2023

Conversation

nicholasbishop
Copy link
Member

This adds support for logging to the event log and extending PCRs, as well as sending raw commands to the TPM. The QEMU test has been updated to cover these features as well.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@nicholasbishop
tpm: Add repr(transparent) to PcrIndex
b3f437e 
This type gets used in some C interfaces, so make sure it is laid out as a
`u32`.
@nicholasbishop
tpm: Fill in the remaining v1 TCG function pointers
1e23b9e 
The `hash_all` function is left as a stub because it's not well-specified how to
free the memory.
@nicholasbishop
tpm: Add v1::PcrEvent::new_in_buffer
b0842d4
@nicholasbishop
tpm: Implement the rest of the v1 public interface
b4b586f 
This adds three new public methods to `v1::Tcg`:
* `log_event`
* `hash_log_extend_event`
* `pass_through_to_tpm`
phip1611
phip1611 reviewed Jan 9, 2023
View reviewed changes
phip1611
phip1611 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@phip1611 phip1611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I don't know anything about the TPMv1 protocol. I trust you know what you are doing 😀

@nicholasbishop
Copy link
Member Author

LGTM but I don't know anything about the TPMv1 protocol. I trust you know what you are doing 😀

I hope so! 😀 The TPM specs are quite complicated, but the QEMU tests give me some confidence that things are correct.

@nicholasbishop nicholasbishop merged commit efff451 into rust-osdev:main Jan 9, 2023
@nicholasbishop nicholasbishop deleted the bishop-tpm1-updates branch January 9, 2023 18:00
@nicholasbishop nicholasbishop mentioned this pull request Jan 12, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phip1611 phip1611 phip1611 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholasbishop @phip1611