Fix warnings from abi_efiapi stabilization
#635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `abi_efiapi` feature has been stabilized, so in the very latest nightlies we
get this warning from enabling it:
the feature `abi_efiapi` has been stable since 1.68.0-nightly and no longer requires an attribute to enable
We don't want to stop using `#![feature(abi_efiapi)]` just yet though, because
that would require raising our nightly MSRV to 2023-01-13. So for now, to get
the CI passing again, turn off the `stable_features` warning.
In the `uefi-macros` tests, just remove `#![feature(abi_efiapi)]` since that
code is only run when developing uefi-rs, not when using it.
nicholasbishop
force-pushed
the
bishop-fix-efiapi-warn
branch
from
b473dad to
3fad8ef
Compare
|
Going to go ahead and merge this to fix the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
abi_efiapifeature has been stabilized, so in the very latest nightlies we get this warning from enabling it:We don't want to stop using
#![feature(abi_efiapi)]just yet though, because that would require raising our nightly MSRV to 2023-01-13. So for now, to get the CI passing again, turn off thestable_featureswarning.In the
uefi-macrostests, just remove#![feature(abi_efiapi)]since that code is only run when developing uefi-rs, not when using it.Checklist