uefi: Fix protocol functions to work with unsized protocols #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
bishop-unsized-proto
branch
from
628325e to
540ab75
Compare
phip1611
approved these changes
Jan 22, 2023
A while ago we changed `DevicePath` to be an unsized type, which necessitated some trait bound changes elsewhere. For example, `open_protocol_exclusive` changed from `P: Protocol` to `P: ProtocolPointer + ?Sized`. However, there are a number of other functions in boot services that take a generic protocol, and they weren't updated so they don't work with unsized protocols. This commit fixes all of those functions.
phip1611
force-pushed
the
bishop-unsized-proto
branch
from
540ab75 to
33f3b5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago we changed
DevicePathto be an unsized type, which necessitated some trait bound changes elsewhere. For example,open_protocol_exclusivechanged fromP: ProtocoltoP: ProtocolPointer + ?Sized. However, there are a number of other functions in boot services that take a generic protocol, and they weren't updated so they don't work with unsized protocols. This commit fixes all of those functions.Checklist