Various fixes for tests under Windows #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
bishop-fix-windows-tests
branch
5 times, most recently
from
043f60c to
913393a
Compare
This is a partial revert of 12a7b44. We still only have one serial device, but on the host it is connected to a pipe rather than stdio. For some reason on Windows, messages sent to QEMU via stdin don't work, but it works fine via pipe. Fixes rust-osdev#647
Rather than a CI flag that did several things, add flags that enable specific tests. Specifically, `multi_processor`, `tpm_v1`, and `tpm_v2`. These three features control whether the corresponding test is enabled, and nothing else. This fixes an issue on Windows where the TPM tests were failing. We had those tests expect to always find a TPM if the CI feature was enabled, but we were also always enabling the CI feature on Windows in order to disable the multi-processing tests, due to KVM not being available. This all becomes a lot simpler by just having explicit flags for each test.
nicholasbishop
force-pushed
the
bishop-fix-windows-tests
branch
from
913393a to
df4eef9
Compare
phip1611
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to fixing the tests under Windows, this PR enables adds running the VM tests under Windows to prevent future accidental breakage.
Checklist