Make more tests fail if protocol is missing #665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already disable the test via feature flags when it's expected to fail. Making it fail instead of warn makes it easier to catch accidental breakage.
Add a feature flag to control whether the test is enabled. Enable it unless the `--disable-network` arg is present. Making the test fail instead of warn makes it easier to catch accidental breakage.
nicholasbishop
force-pushed
the
bishop-no-warn
branch
from
5d1ff57 to
62ee412
Compare
phip1611
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the MP and PXE tests fail if the protocol isn't present. If the tests aren't supposed to pass then they are disabled by feature flag. This makes it easier to catch accidental breakage, since the tests will actually fail with an error instead of just printing a warning.
Checklist