Rework "Building UEFI programs" sections in the readmes #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
bishop-update-top-readme
branch
from
e74402a to
2246f27
Compare
These sections were mostly duplicated between the top-level readme and the `uefi` package's readme. In the top-level readme, it had a broken link to the `BUILDING.md` document which has been deleted. Since we now have "Documentation" sections in both those readmes, the "Building UEFI programs" section was mostly redundent, except for the part about MSRV. Add new MSRV sections, and in the top-level readme just link to the `uefi` package's readme so that we don't have to update both places when the MSRV changes.
nicholasbishop
force-pushed
the
bishop-update-top-readme
branch
from
2246f27 to
0965ff6
Compare
phip1611
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These sections were mostly duplicated between the top-level readme and the
uefipackage's readme. In the top-level readme, it had a broken link to theBUILDING.mddocument which has been deleted.Since we now have "Documentation" sections in both those readmes, the "Building UEFI programs" section was mostly redundent, except for the part about MSRV. Add new MSRV sections, and in the top-level readme just link to the
uefipackage's readme so that we don't have to update both places when the MSRV changes.Checklist