debug everywhere #699
Merged
debug everywhere #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
debug-everywhere
branch
from
d137361 to
b949eda
Compare
nicholasbishop
approved these changes
Mar 24, 2023
phip1611
force-pushed
the
debug-everywhere
branch
from
b949eda to
fb47071
Compare
Exceptions are some union types.
phip1611
force-pushed
the
debug-everywhere
branch
from
fb47071 to
ca16970
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my personal experience, the
this type should implement debug but this notconsideration is not worth it. I think, everything should beDebug, except for sensitive data (such as keys). I often found it frustrating when libraries I used didn't implement Debug for all the types.From a short testing, this didn't change the file size of the uefi runner app. Hence, the overhead is negligible.
What do you think?
Checklist