uefi: debug: add DebugPort protocol #755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is my first time contributing to a rust project. I'll gladly update anything that needs to be updated. This has been tested with SbsaQemu platform after enabling DebugPortDxe driver |
felipebalbi
force-pushed
the
add-debug-port-protocol
branch
from
b2a731f to
a1acd47
Compare
nicholasbishop
requested changes
Apr 6, 2023
felipebalbi
force-pushed
the
add-debug-port-protocol
branch
from
a1acd47 to
36b4b64
Compare
|
@nicholasbishop the API looks a lot cleaner with your suggestions. PR updated, thanks |
felipebalbi
force-pushed
the
add-debug-port-protocol
branch
from
36b4b64 to
0016e36
Compare
felipebalbi
force-pushed
the
add-debug-port-protocol
branch
from
0016e36 to
bc44fba
Compare
DebugPort might be useful for some uefi applications.
felipebalbi
force-pushed
the
add-debug-port-protocol
branch
from
bc44fba to
6fffe57
Compare
nicholasbishop
approved these changes
Apr 6, 2023
phip1611
reviewed
Apr 6, 2023
| debug_port | ||
| .reset() | ||
| .expect("Error while resetting debug port"); | ||
| let data: Vec<_> = r##" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DebugPort might be useful for some uefi applications.