gop: Derive PartialEq on ModeInfo #773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please also derive Eq, then we are good to go :) thanks for the contribution! |
phip1611
approved these changes
Apr 28, 2023
|
@nicholasbishop is github broken? I can't merge but also not rebase.
|
|
Just a guess, but when creating a PR there's an option of whether or not the owners of the repo-being-PR'd-into can edit the branch. Maybe it's unchecked here? @JohnAZoidberg could you rebase this on latest |
To check which mode is currently active, have to compare the ModeInfo structs. https://blog.fpmurphy.com/2015/05/check-available-text-and-graphics-modes-from-uefi-shell.html does the same. Signed-off-by: Daniel Schaefer <dhs@frame.work>
Hm, I thought that was checked. |
|
It's also possible that GitHub was just being weird. At any rate, lgtm now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To check which mode is currently active, have to compare the ModeInfo structs.
https://blog.fpmurphy.com/2015/05/check-available-text-and-graphics-modes-from-uefi-shell.html does the same.
Checklist