Add LoadedImageDevicePath protocol #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
bishop-loaded-image-dp
branch
from
7f456f4
to
c8f414e
Compare
phip1611
reviewed
May 9, 2023
| .node_iter() | ||
| .zip(loaded_image_device_path.node_iter()) | ||
| { | ||
| assert_eq!(n1, n2); |
There was a problem hiding this comment.
This only fails if the UEFI implementation is doing weird stuff, right?
There was a problem hiding this comment.
Right, I think this should always succeed. And per #553, the test is really only for OVMF anyway.
phip1611
approved these changes
May 9, 2023
This protocol is the same as `DevicePath`, but only available on image handles.
nicholasbishop
force-pushed
the
bishop-loaded-image-dp
branch
from
c8f414e
to
e4a1c76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This protocol is the same as
DevicePath, but only available on image handles.Checklist