xtask: Improve QEMU boot time #805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
approved these changes
May 17, 2023
phip1611
force-pushed
the
bishop-speed-up-qemu-boot
branch
from
37c95be to
ff06d3b
Compare
On aarch64 it sits for a while on the initial screen and shows a progress bar to give the user time to enter the boot menu. We don't want to do that in our tests, so set the timeout to zero. Even though we're skipping the boot menu, we have to also enable it here, otherwise the timeout value is ignored and a hardcoded platform default of 3 seconds is used.
nicholasbishop
force-pushed
the
bishop-speed-up-qemu-boot
branch
from
ff06d3b to
60b23be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On aarch64 it sits for a while on the initial screen and shows a progress bar to give the user time to enter the boot menu. We don't want to do that in our tests, so set the timeout to zero.
Even though we're skipping the boot menu, we have to also enable it here, otherwise the timeout value is ignored and a hardcoded platform default of 3 seconds is used.
Checklist