Fix and enable uefi-raw unit/doc tests #816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was copied directly. from `uefi`, so the `use` is wrong. Turns out the tests weren't being run for `uefi-raw` (fixed in the next commit). Since this type is also re-exported in `uefi`, hide the `use` line to avoid confusion about what path to import.
phip1611
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed enabling unit tests for uefi-raw before. This fixes that, and also fixes one error in the doctests.
Since the
Revisiontype is visible from both uefi-raw and uefi, I also hid that line from the rendered docs.Checklist