uefi: Change file reading to read in 1 MiB chunks #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
nicholasbishop
force-pushed
the
bishop-chunked-read-1
branch
from
2177f1f to
4609adb
Compare
Some UEFI implementations have a bug where large reads will incorrectly return an error, so read in 1 MiB chunks to avoid that. The `RegularFile::read` method no longer returns `Option<usize>` in error data, since that is only useful with directory reads. Directory reads continue to use the original unchunked read, which is fine since directory entries should be much smaller than the chunk size. Fixes rust-osdev#825
nicholasbishop
force-pushed
the
bishop-chunked-read-1
branch
from
4609adb to
9464dce
Compare
phip1611
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some UEFI implementations have a bug where large reads will incorrectly return an error, so read in 1 MiB chunks to avoid that.
Fixes #825
Checklist