uefi: Make BootServices a wrapper around uefi_raw::table::boot::BootServices
#863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
reviewed
Jun 19, 2023
uefi/src/table/boot.rs
Outdated
| @@ -94,7 +94,7 @@ struct BootServicesInternal { | |||
|
|
|||
| // Protocol handlers | |||
| install_protocol_interface: unsafe extern "efiapi" fn( | |||
| handle: &mut Option<Handle>, | |||
| handle: *mut uefi_raw::Handle, | |||
There was a problem hiding this comment.
Why can't we use Option<&mut uefi_raw::Handle> here and in similar places? It has the same memory layout as a raw pointer, but we do have more guarantees in higher-level Rust APIs.
There was a problem hiding this comment.
We could, but I'm wary of using any references at all in the uefi-raw interface. Broadly, my thinking is that we want uefi-raw to be as close to the C interface as possible, and in particular placing no restrictions on the API that wouldn't also be present for a C user. My understanding is that a Rust reference, even if it's never dereferenced, must always be valid (aligned, non-dangling), and obey the (currently unfinished) aliasing rules.
phip1611
approved these changes
Jun 19, 2023
This is a transitional type working towards replacing `BootServices` with a transparent wrapper around the `uefi_raw` `BootServices` type. It makes future diffs smaller by taking care of the mechanical change of adding all the `.0` accessors up front.
These are simple cases that just need an `as_ptr()` call to make the types line up.
nicholasbishop
force-pushed
the
bishop-uefi-raw-boot-services-5
branch
from
e073a4c to
59da9b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overall diff here is fairly large, somewhat unavoidable since there are so many functions in BootServices. I've broken it down into smaller commits that should make it clearer how the transformations were done, and also easier to bisect if any bugs are found later.
Checklist