Skip to content

Fix target_arch name: i386 -> x86 #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2023
Merged

Fix target_arch name: i386 -> x86 #891

merged 1 commit into from
Jul 8, 2023

Conversation

nicholasbishop
Copy link
Member

x86 is what will be set on the i686-unknown-uefi target, not i386.

See also https://doc.rust-lang.org/reference/conditional-compilation.html.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@nicholasbishop
Fix target_arch name: i386 -> x86
f95706a 
`x86` is what will be set on the `i686-unknown-uefi` target, not `i386`.

See also https://doc.rust-lang.org/reference/conditional-compilation.html.
@phip1611 phip1611 merged commit d26f914 into rust-osdev:main Jul 8, 2023
@nicholasbishop nicholasbishop deleted the bishop-fix-arch-name branch July 8, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholasbishop @phip1611