Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cargo features / dependencies #676

Merged
merged 2 commits into from
Jan 4, 2019
Merged

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Jan 4, 2019

Fixes #674 and #675

I'm looking at improving the WASM integration testing, but that can be a separate PR.

@dhardy dhardy merged commit ca96671 into rust-random:master Jan 4, 2019
@tomaka
Copy link

tomaka commented Jan 4, 2019

Shouldn't one of the two features be enabled by default?
Right now builds will still break, as people would have to add a manual feature to their Cargo.toml.

@dhardy
Copy link
Member Author

dhardy commented Jan 4, 2019

Both are.

Oh, you're talking about WASM? That's another discussion, and no change since 0.6 (or even 0.5?). A reasonable idea but a new topic — I'm also trying to improve the tests for WASM.

@tomaka
Copy link

tomaka commented Jan 4, 2019

What I mean is that if you create a dummy project, add rand = "0.6" to your Cargo.toml, and try to compile for WASM, you will still get the compile_error! that this PR fixes.
In other words, it is still breaking compared to rand v0.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants