Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rand_os #859

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Fix rand_os #859

merged 1 commit into from
Aug 8, 2019

Conversation

newpavlov
Copy link
Member

Right now rand_os unconditionally enables std feature in rand_core. Issue was raised in #854.

@newpavlov
Copy link
Member Author

IIUC CI failures are not connected to this PR.

@dhardy
Copy link
Member

dhardy commented Aug 8, 2019

I guess this should fix SGX support?

Two changes please:

  1. while I think the licence change is acceptable, I'd prefer it be done on all crates in a separate PR
  2. Don't forget the changelog

One failure is a caching issue, the other two are known issues. So nothing to do with this PR.

@newpavlov
Copy link
Member Author

Done! I've also modified other changelog entries a bit in accordance with https://keepachangelog.com/.

@dhardy
Copy link
Member

dhardy commented Aug 8, 2019

Thanks. I'd prefer you rebase than do an explicit revert if you don't mind?

@newpavlov
Copy link
Member Author

Done.

@dhardy dhardy merged commit 29056a0 into rust-random:master Aug 8, 2019
@newpavlov newpavlov deleted the patch-3 branch August 8, 2019 11:00
@burdges burdges mentioned this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants