Minor cleanups #81
Merged
Minor cleanups #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch removes an unnecessary use of Option in Cmds by calling take() on the whole Vec, instead of on each Cmd.
since this repo appears to be formatted with
cargo fmt --allwith the exception of a single import in examples/dd_test.rs, this patch also formats that import and creates rustfmt.toml as a hint that auto-formatting is ok. that way, i can work on this locally and make commits without having to undo this import change over and over.i’ve also removed some dead code in StderrThread::new(), which i forgot to remove in #79.