Changing as_str into as_cstr #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll fix the comments and also the test that are currently failing. Also, I'll add a test to validate the null terminator. |
andreitraistaru
force-pushed
the
cmdline_as_nul_terminated_string
branch
3 times, most recently
from
aaf0bf1 to
a183e6e
Compare
lauralt
reviewed
Sep 20, 2022
|
Thanks for the review. I'm working on addressing the comments now. I'll ping you when done. |
andreitraistaru
requested review from
lauralt and
andreeaflorescu
and removed request for
andreeaflorescu and
lauralt
andreitraistaru
force-pushed
the
cmdline_as_nul_terminated_string
branch
2 times, most recently
from
4edddce to
44c244c
Compare
andreitraistaru
force-pushed
the
cmdline_as_nul_terminated_string
branch
2 times, most recently
from
ad0ada5 to
19621d6
Compare
andreitraistaru
force-pushed
the
cmdline_as_nul_terminated_string
branch
from
19621d6 to
bdfcd3c
Compare
andreeaflorescu
previously approved these changes
Sep 21, 2022
lauralt
reviewed
Sep 21, 2022
andreitraistaru
force-pushed
the
cmdline_as_nul_terminated_string
branch
from
bdfcd3c to
9dc787c
Compare
andreitraistaru
force-pushed
the
cmdline_as_nul_terminated_string
branch
from
9dc787c to
b485560
Compare
andreitraistaru
requested review from
lauralt and
andreeaflorescu
and removed request for
lauralt
andreitraistaru
force-pushed
the
cmdline_as_nul_terminated_string
branch
from
b485560 to
9d7fe16
Compare
Changing as_str() into as_cstring() in order to retrieve a CString (which is a null terminated string) from the Cmdline struct. We found a bug introduced by the following PR: rust-vmm#72 This bug was caused by the fact that method load_cmdline() was changed to receive a Cmdline instead of a CStr. That leads to the call of the as_str() method from the Cmdline to get the representation of the kernel command line. The method as_str() from Cmdline returns a plain string from Rust that is not null terminated by default. In this commit, we kept the load_cmdline() method to receive a Cmdline but converted the as_str() method into as_cstring() that returns a null terminated string now. Signed-off-by: Traistaru Andrei Cristian <atc@amazon.com>
andreitraistaru
force-pushed
the
cmdline_as_nul_terminated_string
branch
from
9d7fe16 to
ede3cbf
Compare
andreitraistaru
requested review from
lauralt
and removed request for
andreeaflorescu
lauralt
approved these changes
Sep 22, 2022
andreeaflorescu
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing as_str() into as_cstr() in order to retrieve a null terminated string from the Cmdline struct.
Signed-off-by: Traistaru Andrei Cristian atc@amazon.com
Summary of the PR
Please summarize here why the changes in this PR are needed.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
unsafecode is properly documented.