explicit name of the docker container #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not being explicit about where to publish the container, which was leading to a permission denied problem as it was trying to push it to a default repository name called "library". Signed-off-by: Andreea Florescu <fandree@amazon.com>
andreeaflorescu
requested review from
gsserge,
lauralt,
stefano-garzarella and
stsquad
as code owners
Before we were running it only on changes to Dockerfile, but changes to the workflow script can also influence the container buid. Signed-off-by: Andreea Florescu <fandree@amazon.com>
stefano-garzarella
approved these changes
Mar 21, 2023
rbradford
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
We were not being explicit about where to publish the container, which was leading to a permission denied problem as it was trying to push it to a default repository name called "library".
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.