Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsock: Add support for multiple guests #357

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

techiepriyansh
Copy link
Contributor

Adds support for instantiating multiple VhostUserVsockBackends parallely to handle multiple guests. Extends the CLI interface to accept the config for multiple VMs in addition to the yaml config file with the --vm argument as follows:

vhost-user-vsock \
--vm guest_cid=3,socket=/tmp/vhost3.socket,uds_path=/tmp/vm3.vsock \ 
--vm guest_cid=4,socket=/tmp/vhost4.socket,uds_path=/tmp/vm4.vsock

Copy link
Member

@stefano-garzarella stefano-garzarella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM :-), I just left minor comments.

crates/vsock/README.md Show resolved Hide resolved
crates/vsock/src/main.rs Outdated Show resolved Hide resolved
crates/vsock/README.md Show resolved Hide resolved
crates/vsock/src/main.rs Outdated Show resolved Hide resolved
crates/vsock/src/main.rs Outdated Show resolved Hide resolved
crates/vsock/src/main.rs Outdated Show resolved Hide resolved
crates/vsock/src/main.rs Outdated Show resolved Hide resolved
crates/vsock/src/vhu_vsock.rs Outdated Show resolved Hide resolved
crates/vsock/src/main.rs Outdated Show resolved Hide resolved
Adds support for instantiating multiple `VhostUserVsockBackend`s parallely
to handle multiple guests. Extends the CLI interface to accept the config
for multiple VMs in addition to the yaml config file with the `--vm`
argument as follows:

vhost-user-vsock \
--vm guest_cid=3,socket=/tmp/vhost3.socket,uds_path=/tmp/vm3.vsock \
--vm guest_cid=4,socket=/tmp/vhost4.socket,uds_path=/tmp/vm4.vsock

Signed-off-by: Priyansh Rathi <techiepriyansh@gmail.com>
@vireshk vireshk enabled auto-merge (rebase) June 8, 2023 07:33
@vireshk vireshk merged commit a4aabb1 into rust-vmm:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants