Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vhost: support for "standalone" vhost-user daemons #174

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stsquad
Copy link
Contributor

@stsquad stsquad commented Jul 10, 2023

Although originally introduced for VDPA we also want to support this for vhost-user. This requires supporting SET/GET status by moving the trait implementations around and a new message called BACKEND_SPECS which allows the backend to report its capabilities to the VMM as it boots up.

  • Left to do

I suspect I need some extra handling for properly setting things like FEATURES_OK and DEVICE_NEED_RESET. And some tests of course. I shall be shortly posting the RFC patches for QEMU to support this. As such this will be a draft PR for comment for now.

Although originally introduced for VDPA we also have support for
get/set status messages for vhost-user. So lets promote the trait
functions to the main VhostBackend traits while providing a default
implementation which responds for errors (which the Kernel variant
would inherit).

As the status bits are common between backends most of the
implementation details can be handled within the vhost-user traits.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
v2
  - also add impls for DummySlaveReqHandler
  - move VhostVdpa impls to impl<T: VhostKernBackend> VhostBackend for T
This seems like an awful lot of boilerplate (without even any test) to
implement a single message.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant