build(deps): bump rust-vmm-ci from 9dfe5b2 to 665f31f
#185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
requested review from
eryugey,
jiangliu,
sboeuf,
slp and
stefano-garzarella
as code owners
dependabot
bot
added
dependencies
|
@dependabot rebase |
dependabot
bot
force-pushed
the
dependabot/submodules/rust-vmm-ci-665f31f
branch
2 times, most recently
from
3ca70a9
to
eb36ede
Compare
|
I'm going to fix the new clippy warnings, but there is one related to We used an old version that generated also Copy/Clone implementations, but now it looks like they removed it: rust-lang/rust-bindgen#1431 @jiangliu should we regenerate it with a new version of |
Clippy reported the following suggestions:
error: incorrect implementation of `clone` on a `Copy` type
--> crates/vhost/src/vhost_kern/vhost_binding.rs:134:29
|
134 | fn clone(&self) -> Self {
| _____________________________^
135 | | Self::new()
136 | | }
| |_____^ help: change this to: `{ *self }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incorrect_clone_impl_on_copy_type
= note: `#[deny(clippy::incorrect_clone_impl_on_copy_type)]` on by default
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
stefano-garzarella
force-pushed
the
dependabot/submodules/rust-vmm-ci-665f31f
branch
from
eb36ede
to
52c109c
Compare
|
@jiangliu for now I just applied the clippy suggestion, but I'm still thinking if we need to regenerate |
Clippy reported the following suggestions:
error: this if-then-else expression assigns a bool literal
--> crates/vhost/src/vhost_user/backend_req_handler.rs:739:9
|
739 | / if (self.virtio_features & vflag) != 0
740 | | && self.protocol_features.contains(pflag)
741 | | && (self.acked_protocol_features & pflag.bits()) != 0
742 | | {
... |
745 | | self.reply_ack_enabled = false;
746 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign
= note: `-D clippy::needless-bool-assign` implied by `-D warnings`
help: you can reduce it to
|
739 ~ self.reply_ack_enabled = (self.virtio_features & vflag) != 0
740 + && self.protocol_features.contains(pflag) && (self.acked_protocol_features & pflag.bits()) != 0;
|
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Clippy reported the following suggestions:
error: useless use of `vec!`
--> crates/vhost/src/vhost_user/connection.rs:676:20
|
676 | let buf1 = vec![0x1, 0x2, 0x3, 0x4];
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x1, 0x2, 0x3, 0x4]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
= note: `-D clippy::useless-vec` implied by `-D warnings`
error: useless use of `vec!`
--> crates/vhost/src/vhost_user/connection.rs:706:20
|
706 | let buf1 = vec![0x1, 0x2, 0x3, 0x4];
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[0x1, 0x2, 0x3, 0x4]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Bumps [rust-vmm-ci](https://github.com/rust-vmm/rust-vmm-ci) from `9dfe5b2` to `665f31f`. - [Commits](rust-vmm/rust-vmm-ci@9dfe5b2...665f31f) --- updated-dependencies: - dependency-name: rust-vmm-ci dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
After updating the CI the coverage value changed causing failures:
Current code coverage (76.33%) deviates by 7.67% from the
previous code coverage 84.00%.
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
stefano-garzarella
force-pushed
the
dependabot/submodules/rust-vmm-ci-665f31f
branch
from
52c109c
to
bf45e01
Compare
stefano-garzarella
approved these changes
Sep 13, 2023
rbradford
approved these changes
Sep 13, 2023
jiangliu
approved these changes
Sep 14, 2023
dependabot
bot
deleted the
dependabot/submodules/rust-vmm-ci-665f31f
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rust-vmm-ci from
9dfe5b2to665f31f.Commits
665f31fAdd Rust unittest so that test_coverage properly self-tests2148c04Update container version to 26412ecd5Have coverage test use llvm-cov instead of cargo-kcov7c1057etest_commit_format: no longer check body lengthDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)