Make GuestAddressSpace always cloneable #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonzini
requested review from
alexandruag,
jiangliu,
roypat and
ShadowCurse
as code owners
derive(Clone) requires the GuestMemory type parameter of GuestMemoryAtomic to be cloneable as well. However, this is pointless for GuestMemoryAtomic since it is basically an Arc<> wrapper. Make GuestMemoryAtomic<> implement Clone always, just like Arc<>. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
All of our implementation already provide it, just make it part of the interface. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
roypat
previously approved these changes
Aug 12, 2025
bonzini
force-pushed
the
addrspace-cloneable
branch
from
cc8ad09 to
aa290dc
Compare
roypat
approved these changes
Aug 12, 2025
|
Ping @ShadowCurse |
ShadowCurse
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
The idea of
GuestAddressSpaceis that you would distribute as many references to it as needed. However,GuestAddressSpaceitself was not always cloneable becauseGuestMemoryAtomicuses#[derive(Clone)]which in turn requires all type parameters to be cloneable.However, that is not a useful requirement for
GuestMemoryAtomic, which is essentially anArcwrapper. Fix that by implementingCloneby hand; this allowsGuestAddressSpaceto become a subtrait ofCloneas well.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).