Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to libc 0.2, remove unnecessary gl_common crate #658

Closed
wants to merge 2 commits into from

Conversation

mitchmindtree
Copy link
Contributor

I thought I'd open up another PR branch (an alternative to #655) that attempts to update to libc 0.2 and removes the gl_common dependency.

This build succeeds locally on OSX.

@tomaka I don't have a thorough understanding on what gl_common's original role was, however I noticed that you recently removed it from gl-rs, so I thought it might no longer have a place here - let me know if I was wrong and this should be done another way!

@tomaka
Copy link
Contributor

tomaka commented Nov 9, 2015

Conflicts a bit with #652

gl_common was meant to provide a way to replace load_with(|s| window.get_proc_address(s)) with
load(window).

@mitchmindtree
Copy link
Contributor Author

Ahh, wasn't sure if you were still going ahead with #652 - perhaps I should close this and you can go ahead and do this within #652? It seems the libc update and gl_common fixes would need to happen in the same PR.

@tomaka
Copy link
Contributor

tomaka commented Nov 9, 2015

I merged your stuff in #652

@tomaka tomaka closed this Nov 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants