Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh example certificates #174

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Refresh example certificates #174

merged 1 commit into from
Mar 31, 2023

Conversation

djc
Copy link
Member

@djc djc commented Jul 4, 2022

Fixes #173. This is basically a simplified version of https://github.com/rustls/rustls/tree/main/test-ca.

@djc djc requested a review from ctz March 7, 2023 10:22
@djc
Copy link
Member Author

djc commented Mar 7, 2023

@cpu would you be able to dig into these macOS CI failures? FWIW the tests pass locally on my macOS machine (ran them like ~10 times).

@cpu
Copy link
Member

cpu commented Mar 7, 2023

@cpu would you be able to dig into these macOS CI failures? FWIW the tests pass locally on my macOS machine (ran them like ~10 times).

I will take a look today 👍 I don't have super convenient access to MacOS machines locally but it sounds like that won't help in this case. I'll see what I can figure out.

@cpu
Copy link
Member

cpu commented Mar 7, 2023

I'll see what I can figure out.

The problem is not related to this PR (it reproduces on main). I was able to trace this down to a bugfix in curl v7.88.0+. Only the MacOS builder is using this curl version (the Linux instances are on 7.58.0).

I think this is safe to merge whenever it gets a +1 from a maintainer. I'll open a separate PR in the next hour or two with more information on what's going on with curl 7.88 and a fix.

@cpu
Copy link
Member

cpu commented Mar 7, 2023

I'll open a separate PR in the next hour or two with more information on what's going on with curl 7.88 and a fix.

#193

@cpu
Copy link
Member

cpu commented Mar 31, 2023

Merging with one review since this is just test data.

@cpu cpu merged commit 52b5c7a into main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Out-of-date example certificate
2 participants