Builder fixes #283
Merged
Builder fixes #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jens Reidel <adrian@travitia.xyz>
This allows for calling the methods with Arc<CryptoProvider> in a backwards-compatible way. Signed-off-by: Jens Reidel <adrian@travitia.xyz>
cpu
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are two changes to make the most recent hyper-rustls release usable for us in twilight. We also ran into the issue that was fixed by commit c56c76a in our CI, I would be very grateful for a new release with these commits to allow us to finally upgrade rustls.
The first commit adds a method that I think was overlooked when the rustls-platform-verifier support was initially added.
The second commit resolves #282 in a backwards-compatible manner.