Use ALPN by default to negotiate for HTTP2 #95
Conversation
Hyper supports HTTP2, so hyper-rustls should use ALPN to negotiate for HTTP2 by default.
|
The commit builds, Azure Pipelines just timed out for no reason. |
|
Ten seconds of grepping https://github.com/hyperium/hyper-tls and I don't see ALPN being set there either. Do we think that's a bug? Or am I bad at grep? I'd assume hyper-rustls would basically match hyper-tls on behavior. |
|
hyper-tls uses native-tls and the PR for ALPN there has been rejected as not all bindings for the native APIs it uses have ALPN (it's basically blocked by Windows and macOS afaik). |
|
Oh noes :-( Do I understand correctly that, at the moment, hyper's HTTP/2 support is basically never used then? |
|
Yeah for hyper-tls you have to use the force_http2 (or whatever it's called) option that basically just assumes the server can handle HTTP2. For hyper-rustls you have to manually use the From impl for the HttpsConnector to pass the ALPN settings (at least until this PR). However hyper-openssl does proper ALPN by default on all platforms (at the "price" of having to use OpenSSL on Windows and macOS as well). |
|
Thanks, the ecosystem summary was incredibly valuable, I appreciate it |
Hyper supports HTTP2, so hyper-rustls should use ALPN to negotiate for HTTP2 by default.
Resolves #94