Skip to content

Upgrade botan to 0.12 #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2025
Merged

Upgrade botan to 0.12 #377

merged 1 commit into from
Sep 9, 2025

Conversation

djc
Copy link
Member

@djc djc commented Sep 4, 2025

I seem to remember trying this before and something about it was broken, but a quick search doesn't find it.

@djc djc requested review from cpu and est31 September 4, 2025 12:33
@djc
Copy link
Member Author

djc commented Sep 4, 2025

I seem to remember trying this before and something about it was broken, but a quick search doesn't find it.

Ah, that was in #321 (comment) which according to randombit/botan-rs#144 (comment) should be fixed now.

cpu
cpu approved these changes Sep 4, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@djc djc added this pull request to the merge queue Sep 9, 2025
Merged via the queue into main with commit 927e3b3 Sep 9, 2025
16 checks passed
@djc djc deleted the botan-0.12 branch September 9, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@est31 est31 est31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @cpu @est31