Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: dns_name -> server_name. #305

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Conversation

cpu
Copy link
Member

@cpu cpu commented Mar 23, 2023

This commit updates the tests/client.c program to fix a stale reference to the now renamed dns_name field of the rustls_verify_server_cert_params struct. This field is now called server_name to reflect that it may contain an IP address.

This fixes the following build error:

Run make CC=clang PROFILE=release test
mkdir -p target
clang -o target/client.o -c tests/client.c -Werror -Wall -Wextra -Wpedantic -g -I src/ -fsanitize=address -fsanitize=undefined -O3
tests/client.c:37[6](https://github.com/rustls/rustls-ffi/actions/runs/4502338870/jobs/7924017944?pr=303#step:4:7):24: error: no member named 'dns_name' in 'struct rustls_verify_server_cert_params'
          (int)params->dns_name.len,
               ~~~~~~  ^
tests/client.c:3[7](https://github.com/rustls/rustls-ffi/actions/runs/4502338870/jobs/7924017944?pr=303#step:4:8)7:19: error: no member named 'dns_name' in 'struct rustls_verify_server_cert_params'
          params->dns_name.data);
          ~~~~~~  ^
2 errors generated.
Makefile:4[8](https://github.com/rustls/rustls-ffi/actions/runs/4502338870/jobs/7924017944?pr=303#step:4:9): recipe for target 'target/client.o' failed
make: *** [target/client.o] Error 1
Error: Process completed with exit code 2.

This commit updates the `tests/client.c` program to fix a stale
reference to the now renamed `dns_name` field of the
`rustls_verify_server_cert_params` struct. This field is now called
`server_name` to reflect that it may contain an IP address.
@cpu
Copy link
Member Author

cpu commented Mar 23, 2023

With this and #303 combined I think we'll be building 🟢 finally 🎉

@cpu cpu mentioned this pull request Mar 23, 2023
5 tasks
Copy link
Collaborator

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jsha jsha merged commit e939d6f into rustls:rustls-0.21.0 Mar 23, 2023
@cpu cpu deleted the cpu-fix-client-test branch March 23, 2023 16:59
jsha pushed a commit that referenced this pull request Mar 29, 2023
This commit updates the `tests/client.c` program to fix a stale
reference to the now renamed `dns_name` field of the
`rustls_verify_server_cert_params` struct. This field is now called
`server_name` to reflect that it may contain an IP address.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants