rustfmt: style_edition 2024, small CI tweaks #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lifts some configuration we've been using on the main Rustls repo for some time now without issue. The primary advantage is having stale workflow runs automatically cancelled when a branch update is pushed. Historically for this repo I've done that by hand and it's a pain!
Formatting against MSRV is too restrictive. MSRV is primarily for downstream consumers, and not for developers.
ctz
approved these changes
Feb 21, 2025
yedayak
added a commit
to yedayak/rustls-ffi
that referenced
this pull request
Jun 24, 2025
Follow up to 0310085 (rustls#538)
yedayak
added a commit
to yedayak/rustls-ffi
that referenced
this pull request
Jun 24, 2025
Follow up to 0310085 (rustls#538)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci: limit concurrency, auto-cancel stale jobs
This lifts some configuration we've been using on the main Rustls repo for some time now without issue. The primary advantage is having stale workflow runs automatically cancelled when a branch update is pushed.
Historically for this repo I've done that by hand and it's a pain!
ci: format with latest stable rust
Formatting against MSRV is too restrictive. MSRV is primarily for downstream consumers, and not for developers.
rustfmt: style_edition 2024
Like rustls/rustls#2348, rustls/webpki#323 and rustls/pki-types#74 we want to adopt 2024 edition style without actually taking 2024 edition (and breaking semver).
Unlike some other repos,
cargo fix --editionwill produce a diff (primarily small changes related tono_manglebeing marked unsafe, andunsafe fnfunctions not having an automatic function-wideunsafescope). We can't take those until MSRV allows.