api: move WebPkiSupportedAlgorithms to crypto #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1644 +/- ##
=======================================
Coverage 95.71% 95.71%
=======================================
Files 78 78
Lines 16094 16094
=======================================
Hits 15405 15405
Misses 689 689 ☔ View full report in Codecov by Sentry. |
The top level of the crate is meant for "paved path" exports. This newly exported type is used for cryptographic provider customization, so it properly belongs in the `crypto` module.
jsha
force-pushed
the
webpkisupportedalgorithms-not-top-level
branch
from
ea9dddd
to
03ba0d9
Compare
djc
approved these changes
Nov 30, 2023
ctz
approved these changes
Nov 30, 2023
cpu
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The top level of the crate is meant for "paved path" exports.
This newly exported type is used for cryptographic provider customization, so it properly belongs in the
cryptomodule.Related: #1435