performance headlines / landing page #2246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2246 +/- ##
=======================================
Coverage 94.65% 94.65%
=======================================
Files 102 102
Lines 23917 23917
=======================================
Hits 22638 22638
Misses 1279 1279 ☔ View full report in Codecov by Sentry. |
djc
approved these changes
Nov 28, 2024
cpu
approved these changes
Nov 28, 2024
ctz
force-pushed
the
jbp-perf-headlines
branch
2 times, most recently
from
81683f6 to
cfedab1
Compare
I think just for autoreload it has been worth it so far |
ctz
force-pushed
the
jbp-perf-headlines
branch
from
cfedab1 to
627cf45
Compare
|
Could you update the screenshot? I wonder if we could get this to do deploys for PRs... |
done
apparently there is a thing called "GitHub Pages preview" but "This feature is only in alpha currently and is not available to the public!" so maybe this will become easy soon? alternatively we could deploy prs to a throw-away netlify account or similar |
djc
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a little visual display of performance "headlines" to https://rustls.dev/perf/ which looks like:
These are just server TLS1.3 handshake performance, plus TLS1.3 AES-256-GCM transfer rates, which are think is a reasonable
Most of this PR is made up of an extremely "clever" macro, which expands to an SVG I drew in inkscape and sets the dial transforms based on its inputs. I suggest this SVG is treated as write-only :)