Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempted to tackle #1622 #1633

Merged
merged 3 commits into from
Jun 29, 2019
Merged

Attempted to tackle #1622 #1633

merged 3 commits into from
Jun 29, 2019

Conversation

Warfields
Copy link

Trying to fix #1622

@alexcrichton
Copy link
Contributor

Looks great, thanks! Can you be sure to add a smoke test or two as well?

I also think for now we'll probably want to leave bind0 as bind to avoid a breaking change, but we can file an issue about changing it on the next major breaking version?

@Warfields
Copy link
Author

Looks great, thanks! Can you be sure to add a smoke test or two as well?

I also think for now we'll probably want to leave bind0 as bind to avoid a breaking change, but we can file an issue about changing it on the next major breaking version?

Sounds good

@Warfields
Copy link
Author

Warfields commented Jun 28, 2019

@alexcrichton The tests have been written, I've added declarations for both bind() and bind0()

@alexcrichton alexcrichton merged commit bf631ed into rustwasm:master Jun 29, 2019
@alexcrichton
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function::bind2, 3, 4 Are Missing
2 participants