Update release workflow #3680
Open
Update release workflow #3680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combine bump and release into a single step
ranile
commented
Nov 2, 2023
| - run: rustc publish.rs | ||
| - name: assert we're on bump branch | ||
| run: test "$(git git branch --show-current)" = "bump" | ||
| - run: git commit -S -F /tmp/msg |
There was a problem hiding this comment.
Will GitHub handle -S for signed commits properly? Not sure
There was a problem hiding this comment.
As far as I understand you can't with the default git config, but there are some workarounds.
daxpedda
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine bump and release into a single step