Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from js to ini for config file #801

Merged
merged 5 commits into from
Jan 22, 2021
Merged

Move from js to ini for config file #801

merged 5 commits into from
Jan 22, 2021

Conversation

drazisil
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #801 (2d8d673) into master (89c22d3) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #801      +/-   ##
==========================================
- Coverage   47.86%   47.72%   -0.14%     
==========================================
  Files          33       33              
  Lines        1519     1515       -4     
  Branches       61       61              
==========================================
- Hits          727      723       -4     
  Misses        792      792              
Impacted Files Coverage Δ
src/shared/logger.js 100.00% <ø> (ø)
config/app-settings.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c22d3...2d8d673. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jan 22, 2021

This pull request introduces 1 alert when merging bc387b6 into 89c22d3 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@drazisil drazisil merged commit 8cb4a35 into master Jan 22, 2021
@drazisil drazisil deleted the ini-config branch January 22, 2021 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant