Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSDoc all the things! #810

Merged
merged 27 commits into from
Feb 12, 2021
Merged

JSDoc all the things! #810

merged 27 commits into from
Feb 12, 2021

Conversation

drazisil
Copy link
Collaborator

@drazisil drazisil commented Feb 9, 2021

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Feb 9, 2021

This pull request introduces 44 alerts when merging adc033c into e8aa9f1 - view on LGTM.com

new alerts:

  • 42 for Unused variable, import, function or class
  • 1 for Ignoring result from pure array method
  • 1 for Hard-coded credentials

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #810 (c1b9a0c) into main (e8aa9f1) will decrease coverage by 0.01%.
The diff coverage is 55.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
- Coverage   47.47%   47.46%   -0.02%     
==========================================
  Files          33       34       +1     
  Lines        1506     1578      +72     
  Branches       61       67       +6     
==========================================
+ Hits          715      749      +34     
- Misses        791      829      +38     
Impacted Files Coverage Δ
src/services/MCServer/MCOTS/LobbyInfo.js 100.00% <ø> (ø)
src/services/MCServer/ConnectionMgr.js 10.25% <18.18%> (ø)
src/shared/databaseManager.js 20.58% <30.00%> (+5.58%) ⬆️
src/services/MCServer/LoginServer/LoginServer.js 30.90% <33.33%> (ø)
src/services/AuthLogin/AuthLogin.js 44.89% <34.37%> (+11.56%) ⬆️
src/services/MCServer/LobbyServer/LobbyServer.js 19.62% <40.00%> (+1.53%) ⬆️
src/services/MCServer/MCOTS/MessageNode.js 55.35% <40.00%> (+9.90%) ⬆️
src/services/AdminServer/AdminServer.js 33.33% <42.10%> (+3.64%) ⬆️
src/services/MCServer/index.js 36.84% <45.45%> (-10.22%) ⬇️
src/services/MCServer/EncryptionMgr.js 85.18% <60.00%> (-6.12%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8aa9f1...c1b9a0c. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2021

This pull request introduces 48 alerts and fixes 1 when merging 2e54ca2 into e8aa9f1 - view on LGTM.com

new alerts:

  • 46 for Unused variable, import, function or class
  • 1 for Ignoring result from pure array method
  • 1 for Hard-coded credentials

fixed alerts:

  • 1 for Expression has no effect

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2021

This pull request introduces 48 alerts and fixes 1 when merging c53aad8 into e8aa9f1 - view on LGTM.com

new alerts:

  • 46 for Unused variable, import, function or class
  • 1 for Ignoring result from pure array method
  • 1 for Hard-coded credentials

fixed alerts:

  • 1 for Expression has no effect

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2021

This pull request introduces 48 alerts and fixes 1 when merging 603394d into e8aa9f1 - view on LGTM.com

new alerts:

  • 46 for Unused variable, import, function or class
  • 1 for Ignoring result from pure array method
  • 1 for Hard-coded credentials

fixed alerts:

  • 1 for Expression has no effect

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2021

This pull request introduces 51 alerts and fixes 1 when merging 7175bd7 into e8aa9f1 - view on LGTM.com

new alerts:

  • 49 for Unused variable, import, function or class
  • 1 for Ignoring result from pure array method
  • 1 for Hard-coded credentials

fixed alerts:

  • 1 for Expression has no effect

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2021

This pull request introduces 57 alerts and fixes 1 when merging e60abfd into e8aa9f1 - view on LGTM.com

new alerts:

  • 55 for Unused variable, import, function or class
  • 1 for Ignoring result from pure array method
  • 1 for Hard-coded credentials

fixed alerts:

  • 1 for Expression has no effect

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2021

This pull request introduces 51 alerts and fixes 1 when merging f25ba1f into e8aa9f1 - view on LGTM.com

new alerts:

  • 49 for Unused variable, import, function or class
  • 1 for Ignoring result from pure array method
  • 1 for Hard-coded credentials

fixed alerts:

  • 1 for Expression has no effect

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2021

This pull request introduces 41 alerts and fixes 1 when merging fc78a75 into e8aa9f1 - view on LGTM.com

new alerts:

  • 39 for Unused variable, import, function or class
  • 1 for Ignoring result from pure array method
  • 1 for Hard-coded credentials

fixed alerts:

  • 1 for Expression has no effect

@ghost
Copy link

ghost commented Feb 12, 2021

DeepCode's analysis on #c1b9a0 found:

  • ℹ️ 1 minor issue. 👇

Top issues

Description Example fixes
Missing JSDoc for parameter 'response'. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@drazisil drazisil merged commit bc48b63 into main Feb 12, 2021
@drazisil drazisil deleted the web-handling branch February 12, 2021 06:18
@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2021

This pull request introduces 38 alerts and fixes 1 when merging c1b9a0c into e8aa9f1 - view on LGTM.com

new alerts:

  • 36 for Unused variable, import, function or class
  • 1 for Ignoring result from pure array method
  • 1 for Hard-coded credentials

fixed alerts:

  • 1 for Expression has no effect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant