Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting and tests refactor #812

Merged
merged 4 commits into from
Feb 13, 2021
Merged

Formatting and tests refactor #812

merged 4 commits into from
Feb 13, 2021

Conversation

drazisil
Copy link
Collaborator

Bring tests inline with their files, and create a ESLint rule.

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #812 (a1ecbb3) into main (f7c3efa) will increase coverage by 0.18%.
The diff coverage is 59.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
+ Coverage   47.46%   47.64%   +0.18%     
==========================================
  Files          34       22      -12     
  Lines        1578     1020     -558     
  Branches       67       36      -31     
==========================================
- Hits          749      486     -263     
+ Misses        829      534     -295     
Impacted Files Coverage Δ
src/services/MCServer/MCOTS/LobbyMsg.js 77.77% <ø> (-1.17%) ⬇️
src/services/MCServer/MCOTS/MessageNode.js 55.35% <0.00%> (ø)
src/services/MCServer/LobbyServer/LobbyServer.js 17.92% <16.66%> (-1.71%) ⬇️
src/services/AdminServer/AdminServer.js 29.23% <22.22%> (-4.11%) ⬇️
src/services/MCServer/ConnectionObj.js 59.45% <40.00%> (-1.07%) ⬇️
src/services/MCServer/MCOTS/StockCarInfoMsg.js 40.00% <66.66%> (-1.94%) ⬇️
src/services/PatchAndShard/patchServer.js 70.00% <70.00%> (-0.66%) ⬇️
...c/services/MCServer/PersonaServer/PersonaServer.js 64.82% <80.00%> (-0.48%) ⬇️
src/services/MCServer/ClientConnectMsg.js 65.00% <100.00%> (ø)
src/services/MCServer/GenericReplyMsg.js 52.77% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7c3efa...a1ecbb3. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2021

This pull request fixes 36 alerts when merging 6e56666 into f7c3efa - view on LGTM.com

fixed alerts:

  • 36 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2021

This pull request fixes 36 alerts when merging 3362d3f into f7c3efa - view on LGTM.com

fixed alerts:

  • 36 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2021

This pull request fixes 36 alerts when merging cb787eb into f7c3efa - view on LGTM.com

fixed alerts:

  • 36 for Unused variable, import, function or class

@ghost
Copy link

ghost commented Feb 12, 2021

Congratulations 🎉. DeepCode analyzed your code in 6.654 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2021

This pull request fixes 36 alerts when merging a1ecbb3 into f7c3efa - view on LGTM.com

fixed alerts:

  • 36 for Unused variable, import, function or class

@drazisil drazisil merged commit ac86e1c into main Feb 13, 2021
@drazisil drazisil deleted the directory-redesign branch February 13, 2021 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant