Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript #820

Merged
merged 5 commits into from
Feb 21, 2021
Merged

Typescript #820

merged 5 commits into from
Feb 21, 2021

Conversation

drazisil
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #820 (af960c3) into main (6d7a979) will increase coverage by 8.27%.
The diff coverage is 78.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #820      +/-   ##
==========================================
+ Coverage   47.80%   56.07%   +8.27%     
==========================================
  Files          22       22              
  Lines        1023     1054      +31     
  Branches       36       44       +8     
==========================================
+ Hits          489      591     +102     
+ Misses        534      452      -82     
- Partials        0       11      +11     
Impacted Files Coverage Δ
src/services/MCServer/LobbyServer/LobbyServer.ts 26.78% <45.16%> (ø)
src/services/MCServer/MCOTS/MCOTServer.ts 21.15% <53.84%> (ø)
src/services/MCServer/MCOTS/StockCar.ts 52.38% <54.54%> (ø)
...rvices/MCServer/PersonaServer/NPSPersonaMapsMsg.ts 41.86% <55.00%> (ø)
src/services/MCServer/LobbyServer/npsUserInfo.ts 77.27% <63.63%> (ø)
src/services/MCServer/LoginServer/LoginServer.ts 35.08% <64.70%> (ø)
src/services/MCServer/listenerThread.ts 65.85% <83.33%> (ø)
src/services/MCServer/MCOTS/LobbyMsg.ts 89.47% <85.71%> (ø)
src/services/MCServer/MCOTS/LoginMsg.ts 91.89% <88.88%> (ø)
...c/services/MCServer/PersonaServer/PersonaServer.ts 67.09% <90.62%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d7a979...af960c3. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Feb 21, 2021

This pull request introduces 2 alerts and fixes 5 when merging 50b4270 into 6d7a979 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Hard-coded credentials

fixed alerts:

  • 3 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable
  • 1 for Hard-coded credentials

@lgtm-com
Copy link

lgtm-com bot commented Feb 21, 2021

This pull request introduces 2 alerts and fixes 5 when merging d87c461 into 6d7a979 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable
  • 1 for Hard-coded credentials

fixed alerts:

  • 3 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable
  • 1 for Hard-coded credentials

@ghost
Copy link

ghost commented Feb 21, 2021

DeepCode's analysis on #af960c found:

  • ℹ️ 1 minor issue. 👇

Top issues

Description Example fixes
Array type using 'T[]' is forbidden for non-simple types. Use 'Array' instead. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@drazisil drazisil merged commit d4e0094 into main Feb 21, 2021
@drazisil drazisil deleted the typescript branch February 21, 2021 04:44
@lgtm-com
Copy link

lgtm-com bot commented Feb 21, 2021

This pull request introduces 1 alert and fixes 5 when merging af960c3 into 6d7a979 - view on LGTM.com

new alerts:

  • 1 for Hard-coded credentials

fixed alerts:

  • 3 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable
  • 1 for Hard-coded credentials

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant