Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rework lib/bin.js inclusion in ipjx compile chain #56

Merged
merged 2 commits into from
May 12, 2022
Merged

Conversation

rvagg
Copy link
Owner

@rvagg rvagg commented May 12, 2022

  • was included as an import in test/node-test-bin.js just to get it in the
    compile chain
  • mocha now doing ESM (I think) is loading node-test-bin.js as ESM and it's
    executing bin.js as it's loaded -- this didn't happen prior to mocha@10
  • only seeing this in CI for Windows, could be to do with the way mocha is
    loaded for now
  • moving the import to test/noop-bin-test.js which isn't run as part of the
    test suite, but will be picked up by ipjs --tests

PR also includes #53

dependabot bot and others added 2 commits May 12, 2022 12:44
Bumps [mocha](https://github.com/mochajs/mocha) from 9.2.2 to 10.0.0.
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md)
- [Commits](mochajs/mocha@v9.2.2...v10.0.0)

---
updated-dependencies:
- dependency-name: mocha
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
* was included as an import in test/node-test-bin.js just to get it in the
  compile chain
* mocha now doing ESM (I think) is loading node-test-bin.js as ESM and it's
  executing bin.js as it's loaded -- this didn't happen prior to mocha@10
* only seeing this in CI for Windows, could be to do with the way mocha is
  loaded for now
* moving the import to test/noop-bin-test.js which isn't run as part of the
  test suite, but will be picked up by `ipjs --tests`
@rvagg rvagg merged commit 7b3cd32 into master May 12, 2022
@rvagg rvagg deleted the rvagg/win-prob branch May 12, 2022 03:03
@github-actions
Copy link

🎉 This PR is included in version 1.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant