Trees with multiple roots #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jannertje
reviewed
Sep 18, 2019
Jannertje
reviewed
Sep 18, 2019
Jannertje
reviewed
Sep 18, 2019
| root_tree_space = uniform_index_tree(2, 'x') | ||
| root = DebugDoubleNode((root_tree_time, root_tree_space)) | ||
| left, right = root.refine(0) | ||
| meta_root_time = uniform_index_tree(2, 't', FakeHaarNode) |
There was a problem hiding this comment.
kan je bij deze test case opschrijven wat 'ie meot testen? vooral die "with pyutest.raises" is voor mij niet zo duidelijk meer
Jannertje
reviewed
Sep 18, 2019
Python/spacetime/applicator_test.py
Outdated
| assert [n.nodes[0].labda for n in sigma.bfs()] == [(0, 0), (0, 0), (0, 0)] | ||
| assert [n.nodes[1].labda for n in sigma.bfs()] == [(0, 0), (1, 0), (1, 1)] | ||
| assert [n.nodes[0].labda | ||
| for n in sigma.bfs(include_meta_root=False)] == [(0, 0), (0, 0), |
There was a problem hiding this comment.
is het misschien natuurlijker om include_meta_root default op False te zetten? dan komen we die metaroots niet tegen in het BFS'en, tenzij we "er om vragen"
Jannertje
reviewed
Sep 18, 2019
| sigma.root.union(self.Lambda_in.project(0), i=0) | ||
| sigma.root.union(self.Lambda_out.project(1), i=1) |
There was a problem hiding this comment.
wacht wacht waarom ook deze tweede projectie er in gooien? zodat we de meta-roots hebben gebouwd zeker?
There was a problem hiding this comment.
Ja zie comment erboven.
Jannertje
reviewed
Sep 18, 2019
|
PTAL |
Jannertje
reviewed
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the case that trees have multiple roots. It is done by adding a
meta rootto trees; this node holds a reference to all the actual roots.