Update gem and CI for more recent ruby versions #8
Conversation
kind of: EDEPRECATED: global use of wont_equal from test/gem-empty/specification_and_version_test.rb:24. Use _(obj).wont_equal instead. This will fail in Minitest 6.
Kind of: warning: `if' at the end of line without an expression
Kind of: test/gem-empty/command_test.rb:8: warning: method redefined; discarding old remove_spec
it is no longer working
|
CI looks like so: https://github.com/larskanis/gem-empty/actions/runs/3952435065 |
|
@pkuczynski Could you please review this PR? |
|
Running into issues with |
| subject.defaults_str.class.must_equal(String) | ||
| subject.description.class.must_equal(String) | ||
| subject.program_name.class.must_equal(String) | ||
| _(subject.arguments.class).must_equal(String) |
There was a problem hiding this comment.
As written in the commit message, this was the minitest recommendation:
DEPRECATED: global use of wont_equal from test/gem-empty/specification_and_version_test.rb:24. Use _(obj).wont_equal instead. This will fail in Minitest 6.
| - os: ubuntu | ||
| ruby: "3.2" | ||
| - os: ubuntu | ||
| ruby: "2.5" |
There was a problem hiding this comment.
if the tests runs sufficiently fast, we could include a lot more versions here...
test/test_helper.rb
Outdated
| if | ||
| RUBY_VERSION == "2.0.0" # check Gemfile | ||
| then | ||
| if RUBY_VERSION == "2.0.0" # check Gemfile |
There was a problem hiding this comment.
test no longer run on 2.0.0 as far as I can see, which means no code coverage....
|
Thanks for porting to Github actions, this is sure a good change. last run: |
Since the CI runs are reasonable fast.
since this is the oldest version we test in CI
and remove ruby-2.0 specifics
since it fails on ruby-2.7 and seems to be no longer necessary for the tests to succeed.
|
I addressed the comments above. CI run looks like so now: https://github.com/larskanis/gem-empty/actions/runs/4207194540/jobs/7301680135 Coverage reporting to coveralls.io doesn't work and prints some warning into the log. Can coveralls be removed? |
|
rvm's |
|
I separated all the changes into district commits, so that cherry picking is also an option. Although I think that all the changes are reasonable to bring the gem to an up-to-date level. |
|
Let me have a look at proposed changes... |
|
@mojavelinux 1.2.0 released. Let me know if you find any issue |
|
@larskanis I am not sure what did I missed when cherrypicking from this PR, but |
|
Thanks for your work on this @larskanis. Hope you didnt mind me cherypicking form this PR instead of merging. I wanted to keep more backward compatibility... |
|
Success! Thanks a bunch! |
I noticed this while trying to fix the rvm CI.
Would be nice to have a new release on rubygems.org so that it can be used in the rvm CI.