Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI by bumping ancient rubies 2.4.0, 2.4.1, 2.6.6 into 3.0.5, 3.1.2, 3.1.3 in tests #5313

Merged
merged 14 commits into from
Feb 16, 2023

Conversation

mathieujobin
Copy link
Contributor

Changes proposed in this pull request:

  • bump 2.4.0 on the prepare step. the gemset error is common with old rubies now...
  • Make sure that your pull request includes entry in the CHANGELOG.

@pkuczynski pkuczynski changed the title Fix CI Bump 2.4.0 to 3.0.5 in CI tests Feb 14, 2023
@pkuczynski pkuczynski added this to the rvm-1.29.13 milestone Feb 14, 2023
@pkuczynski pkuczynski added the CI label Feb 14, 2023
pkuczynski
pkuczynski previously approved these changes Feb 14, 2023
Copy link
Member

@pkuczynski pkuczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to bump it and don't worry too much about old rubies. @mpapis @raelgc what do you think?

@eregon
Copy link
Contributor

eregon commented Feb 14, 2023

If this fixes the CI, definitely.

Copy link
Contributor

@raelgc raelgc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is still failing about 2.6

@mathieujobin mathieujobin changed the title Bump 2.4.0 to 3.0.5 in CI tests Fix CI by bumping ancient rubies 2.4.0,2.4.1,2.6.6 into 3.0.5,3.1.2,3.1.3 in CI tests Feb 15, 2023
@mathieujobin
Copy link
Contributor Author

mathieujobin commented Feb 15, 2023

Before:
image

Current:
image

@mathieujobin
Copy link
Contributor Author

I'd like some help on this one...

macos-latest all pass, no errors.

https://github.com/rvm/rvm/actions/runs/4181029459/jobs/7242562592

ubuntu, the 970 test cases finally also passed...

but on the following step, tf command is reported as not found... makes no sense,.. since its available in the step above

I guess, that step is skipped on macos, so maybe we could skip as well.

@larskanis
Copy link
Member

Some CI tests depend on gem-empty, which doesn't run on ruby-3.2+. I opened a PR to fix this and a lot of other warnings: rvm/gem-empty#8

@mathieujobin
Copy link
Contributor Author

@larskanis I have not seen any failure caused by gem-empty.. and all test pass now
@pkuczynski We can merge this...

@pkuczynski pkuczynski changed the title Fix CI by bumping ancient rubies 2.4.0,2.4.1,2.6.6 into 3.0.5,3.1.2,3.1.3 in CI tests Fix CI by bumping ancient rubies 2.4.0, 2.4.1, 2.6.6 into 3.0.5, 3.1.2, 3.1.3 in tests Feb 16, 2023
@pkuczynski pkuczynski merged commit 6ccf5ac into rvm:master Feb 16, 2023
havenwood pushed a commit to havenwood/rvm-1 that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants