Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Swedish language #733

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Added Swedish language #733

merged 2 commits into from
Jan 18, 2022

Conversation

Sopor
Copy link
Contributor

@Sopor Sopor commented Jan 17, 2022

I'm not a macOS user so bear with me if i made some mistake. Some strings should be easier to translate with some kind of context. If you find any errors or if you think you can improve it, you are free to do so.

@rxhanson rxhanson merged commit df7a6e9 into rxhanson:master Jan 18, 2022
@rxhanson
Copy link
Owner

Thanks!!

@Sopor
Copy link
Contributor Author

Sopor commented Jan 20, 2022

@rxhanson I noticed that you changed sv-SE to sv.

In Finland they speak Swedish too and to separate these two you use sv-SE instead of only sv. Finnish locale is sv-FI.

There are differences in linguistics and vocabulary between them (how much i don't know). Currency, telephone codes, and stuff like that are also different.

You do have pt-BR and pt-PT, so why not sv-SE? Doesn't macOS has sv-SE and sv-FI locales?

@rxhanson
Copy link
Owner

Ah, sorry. When I added the localization, for some reason sv was all that popped up. Upon further inspection, there are all of the additional locales. I went ahead and changed it back to sv-SE. With just sv, I think it would have just used this localization for all the Swedish ones, which isn't that bad because it would prompt Swedish speaking users from other locales to contribute (based on other localizations I've had :). Either way, best to have it be your intended locale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants