Bug Fix for #713 #742
Merged
Bug Fix for #713 #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Application windows now consider the dock positition and will not be placed underneath the dock 1. todoWindow uses the adjustedVisibleFrame(which uses visibleFrame). When the dock is set to the right side, todoWindow will now placed next to it rather than under it 2. adjustedVisibleFrame is now used to calculate the positions for all non-todo application windows. 3. Changed the following in the shiftWindowOffSidebar function a. Uses adjustedVisibleFrame instead of screenFrame. Helps when dock is placed on the left side b. Handles an edge case where an application window is already placed at left edge or even further left. Origin X will be its current x in this case c. The condition for checking if the application window is too wide. It now considers the edge case above.
1 task
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rectangle Version 0.50 (55)
Fix for #713
Application windows now consider the dock positition and will not be placed underneath the dock
a. Uses adjustedVisibleFrame instead of screenFrame. Helps when dock is placed on the left side
b. Handles an edge case where an application window is already placed at left edge or even further left. Origin X will be its current x in this case
c. The condition for checking if the application window is too wide. It now considers the edge case above.