Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set shortcut to "Shift Left/Right/Up/Down" #5

Closed
jingzhehu opened this issue Jul 22, 2019 · 6 comments
Closed

Can't set shortcut to "Shift Left/Right/Up/Down" #5

jingzhehu opened this issue Jul 22, 2019 · 6 comments
Labels
wontdo This will not be worked on

Comments

@jingzhehu
Copy link

jingzhehu commented Jul 22, 2019

@rxhanson Thanks for making this app available !

The problem I have is that I can't set any shortcut to something like "Shift Left" - it just won't be recorded. Could you take a look and help me resolve the issue ?

@rxhanson rxhanson added the wontdo This will not be worked on label Jul 23, 2019
@rxhanson
Copy link
Owner

@jingzhehu thanks for using the app!

The shortcut recorder doesn't allow shortcuts that are already in use by the OS. Shift+arrow is used globally to highlight text.

At this time, I don't have plans to change this behavior to allow Shift+arrow. It is a really easy change to make in the code, though. If you want to fork it and make the changes, I can walk you through it.

Sorry, probably not the answer you were looking for, but I'm going to close this as "works as intended".

@jingzhehu
Copy link
Author

Got it and thanks in advance ! Could you point me to the relevant source codes ?

@rxhanson
Copy link
Owner

I made a quick branch that does what you want. Let me know if you have any questions.
https://github.com/rxhanson/Rectangle/compare/allow-any-shortcut

@jingzhehu
Copy link
Author

@rxhanson Works perfectly ! Really appreciate your help.

Somehow cocoapod complains about Unable to find a target named RectangleMAS. The project builds fine after commenting out the RectangleMAS section in Podfile and changing some code signing related things.

@rxhanson
Copy link
Owner

Thanks for being the first Guinea Pig and letting me know :)

I removed the RectangleMAS target and reset Xcode to codesign locally in master for the next tinkerers that come along.

If you don't mind, it would help to star the project in GitHub so that it can gain more interest. That will also help me get to 50 stars to add it to brew cask for easy install. Thanks!

@rxhanson
Copy link
Owner

@jingzhehu figured I'd let you know that I added the changes for allowing any shortcut into v0.4, so you can get back on the main release track if you want. It's a checkbox in the settings tab of the preferences window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontdo This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants