Ipad touch-away handling #15
Conversation
| closeButton = wrapper.find(CloseButton); | ||
| }); | ||
|
|
||
| it(`${React.version} - asdmatches the previous snapshot`, () => { |
There was a problem hiding this comment.
This stuff is pretty much all just indentation changes, as I wrapped them in an extra describe declaration.
| ); | ||
| }); | ||
|
|
||
| describe('touch devices -', () => { |
| handleTouch = ({ target }: Event) => { | ||
| const { activeElement } = document; | ||
|
|
||
| if (!(activeElement instanceof Element) || !(target instanceof Element)) |
There was a problem hiding this comment.
In acc-css-app we're testing for instanceof HTMLElement, but this would not catch HTMLBodyElement for example. Element is a bit of a broader net.
There was a problem hiding this comment.
Aren't we going to apply this as well at line 70?
There was a problem hiding this comment.
We could, but it's a bit of a moot point because it's not possible for a label component to be an HTMLBodyElement.
| }; | ||
|
|
||
| hide = (): void => { | ||
| hide = () => { |
There was a problem hiding this comment.
Is keeping void a problem?
There was a problem hiding this comment.
For some reason it breaks syntax highlighting in my IDE :(
It doesn't matter though because Flow will infer the return types.
Basically an upstream-retrofit of the logic from
acc-css-appto add touch-away handling for iOS devices who don't actually trigger a 'blur' on focussed elements when touching-away from the element.