Feature / improvement request: uncache iterator when new language is added

[teppokoivula]

Once again title may be a bit off, but this is the problem I'm having:

At the moment wire('modules')->LanguageSupport->otherLanguagePageIDs contains up-to-date list of additional languages and count(wire('languages')) returns up-to-date number of all available languages.. yet wire('languages'), when iterated, does not contain languages added during that request.

It's not exactly clear to me why this is happening and whether this is actually something that Countable and IteratorAggregate do differently (?), but it's a bit confusing to say the least.

I'd be happy if there was a clean way to "uncache" languages iterator (at least I haven't been able to find such a method yet), but it would seem even more sensible if new languages becoming instantly usable, i.e. iterator refreshing automatically.

Not entirely sure about that part, but I'm guessing that this also applies to other classes extending PagesType, not just Languages.

[ryancramerdesign]

count() is coming from PagesType whereas iterating Languages is coming from the Languages class (which extends PagesType). The count() value comes from a numChildren() call rather than from a count() of the Languages object. The languages API var is another example of one that was intended to be static for the duration of the request, so the kind of stuff you mentioned here hasn't been considered. I've attempted a fix in the latest commit. Can you let me know if this resolves the issue?

[ryancramerdesign]

Never mind about that last update. Looks like resetting the languages API var us too problematic as I ended up with a corrupted database after a few language adds/removes. I'll look into this more. But for now I've added a reloadLanguages() method to the $languages API var, if you want to try that out and see if you can get what you need from it.

[teppokoivula]

@ryancramerdesign: thanks, this solves the problem for me.

.. and again, sorry for sending requests that are somewhat out of scope for regular use. I've worked quite extensively with the API lately and found certain obscure issues that definitely won't affect most users. I'm very grateful that you've been able to spend time on these!